[Feature/PDOAAC-6302] (issue/137) add in small notificaiton on using -gr flag
#179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenes56
approved these changes
Mar 6, 2025
mike-gangl
reviewed
Mar 6, 2025
subscriber/podaac_data_downloader.py
Outdated
| @@ -280,6 +280,9 @@ def cmr_downloader(args, token, data_path): | |||
| if args.verbose: | |||
| logging.info(str(results['hits']) + " granules found for " + short_name) # noqa E501 | |||
|
|
|||
| if granule is not None and results['hits'] == 0: | |||
| logging.info("** 0 granules found with -gr (granuleUR) flag; tried using wildcards (*/%)? **") | |||
There was a problem hiding this comment.
a user may takes this one of two ways:
- are you attempting to use wild cards?
- have you tried using wild cards here? it might be helpful?
Recommend changing this to something clearer:
0 granules found with -gr (granuleUR) flag; You may want to try using wildcards (*/%) in the granuleUR?
There was a problem hiding this comment.
Gotcha; updated formatting and wording
mike-gangl
requested changes
Mar 6, 2025
|
What's going on with the tests? |
|
@mike-gangl sorry that was due to the previous PR (that fixed a test) hasn't been merged into develop and into this branch; this time the tests should pass (except for 3.7) 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing in a small notification when -gr flag is used and no results have returned
looks like follows